Clear findfont cache when calling addfont(). #21278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Oct 15, 2021
QuLogic
reviewed
Oct 15, 2021
QuLogic
approved these changes
Oct 15, 2021
... as new fonts may invalidate previous searches (e.g. a previous findfont may have chosen to return an approximate match, whereas the newly added font is an exact match). No test, as there is no machinery to *remove* a font from FontManager yet so we add a font just temporarily within the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... as new fonts may invalidate previous searches (e.g. a previous
findfont may have chosen to return an approximate match, whereas the
newly added font is an exact match).
No test, as there is no machinery to remove a font from FontManager
yet so we add a font just temporarily within the test.
This should close #16581.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).